Forums
|
|
|
Page 1 of 1
|
[ 6 posts ] |
|
Fixed-position elements and mispaced PIE rendering
Author |
Message |
travisjhall
Joined: Tue Aug 31, 2010 2:33 am Posts: 3
|
 Fixed-position elements and mispaced PIE rendering
|
Tue Aug 31, 2010 5:47 am |
|
 |
jason
Joined: Wed Jul 14, 2010 11:46 am Posts: 1452
|
 Re: Fixed-position elements and mispaced PIE rendering
Thanks a lot for this, Travis, it's a great help.
Would you mind opening an issue ticket in GitHub for this? That will make sure it doesn't get lost and serves as a checklist for me.
Reading over your code changes I think you're right that it works fine if the position:fixed element is a child of the body, but if the position:fixed element is a descendant of another positioned element then it won't work right because it still subtracts the position of that parent element.
Actually I think that if it's position:fixed we can shortcut past all the getBoundingClientRect stuff and just use the left/top/bottom/right currentStyle properties of the target element directly (except in IE6 of course, which we'd let fall through to the current code). Do you see any problems with that?
I'd also want to verify that this method of positioning responds correctly when the element moves due to animation etc.
|
Tue Aug 31, 2010 11:25 am |
|
 |
travisjhall
Joined: Tue Aug 31, 2010 2:33 am Posts: 3
|
 Re: Fixed-position elements and mispaced PIE rendering
|
Tue Aug 31, 2010 7:31 pm |
|
 |
jason
Joined: Wed Jul 14, 2010 11:46 am Posts: 1452
|
 Re: Fixed-position elements and mispaced PIE rendering
Thanks, Travis, I'll try to get your changes integrated when I have time.
|
Wed Sep 01, 2010 8:38 am |
|
 |
travisjhall
Joined: Tue Aug 31, 2010 2:33 am Posts: 3
|
 Re: Fixed-position elements and mispaced PIE rendering
Yeah, no problem. Don't rush yourself. The reason I put some work into diagnosing the issue is so that I can fix it myself, for my own purposes, straight away, so I'm not affected by the wait for you to fix it. With the sample code I posted, others can do their own temporary fixes too.
And thank you for what you've already done on PIE. Even if it isn't (yet) perfect, it's still a lot less work than implementing the same stuff from scratch.
|
Wed Sep 01, 2010 4:37 pm |
|
 |
peterbowey
Joined: Thu Sep 09, 2010 9:06 pm Posts: 1
|
 Re: Fixed-position elements and mispaced PIE rendering
|
Thu Sep 09, 2010 9:21 pm |
|
|
|
Page 1 of 1
|
[ 6 posts ] |
|
Who is online |
Users browsing this forum: No registered users and 5 guests |
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot post attachments in this forum
|
|